This commit addresses several code review comments primarily focused on improving the rendering and stability of the CLI UI. Key changes include: - Passing `isPending` and `availableTerminalHeight` props to `MarkdownDisplay` to enable more intelligent rendering of content, especially for pending messages and code blocks. - Adjusting height calculations in `ToolGroupMessage` and `ToolMessage` to more accurately reflect available space. - Refining the logic in `App.tsx` for measuring and utilizing terminal height, including renaming `footerRef` to `mainControlsRef` for clarity. - Ensuring consistent prop drilling for `isPending` and `availableTerminalHeight` through `HistoryItemDisplay`, `GeminiMessage`, and `GeminiMessageContent`. - In `MarkdownDisplay`, when `isPending` is true and content exceeds `availableTerminalHeight`, the code block will now be truncated with a "... generating more ..." message. If there's insufficient space even for the message, a simpler "... code is being written ..." will be shown.
40 lines
920 B
TypeScript
40 lines
920 B
TypeScript
/**
|
|
* @license
|
|
* Copyright 2025 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import React from 'react';
|
|
import { Text, Box } from 'ink';
|
|
import { MarkdownDisplay } from '../../utils/MarkdownDisplay.js';
|
|
import { Colors } from '../../colors.js';
|
|
|
|
interface GeminiMessageProps {
|
|
text: string;
|
|
isPending: boolean;
|
|
availableTerminalHeight: number;
|
|
}
|
|
|
|
export const GeminiMessage: React.FC<GeminiMessageProps> = ({
|
|
text,
|
|
isPending,
|
|
availableTerminalHeight,
|
|
}) => {
|
|
const prefix = '✦ ';
|
|
const prefixWidth = prefix.length;
|
|
|
|
return (
|
|
<Box flexDirection="row">
|
|
<Box width={prefixWidth}>
|
|
<Text color={Colors.AccentPurple}>{prefix}</Text>
|
|
</Box>
|
|
<Box flexGrow={1} flexDirection="column">
|
|
<MarkdownDisplay
|
|
text={text}
|
|
isPending={isPending}
|
|
availableTerminalHeight={availableTerminalHeight}
|
|
/>
|
|
</Box>
|
|
</Box>
|
|
);
|
|
};
|