81f0f618f7
- The tl;dr; is that GC couldn't see what the user was saying when tool call events happened in response. The rason why this was happening was because we were instantly invoking tools that the model told us to invoke and then instantly re-requesting. This resulted in the bug because the genai APIs can't update the chat history before a full response has been completed (doesn't know how to update if it's incomplete). - To address the above issue I had to do quite the large refactor. The gist is that now turns truly drive everything on the server (vs. a server client split). This ensured that when we got tool invocations we could control when/how re-requesting would happen and then also ensure that history was updated. This change also meant that the server would act as an event publisher to enable the client to react to events rather than try and weave in complex logic between the events. - A BIG change that this changeset incudes is the removal of all of the CLI tools in favor of the server tools. - Removed some dead code as part of this - **NOTE: Confirmations are still broken (they were broken prior to this); however, I've set them up to be able to work in the future, I'll dot hat in a follow up to be less breaking to others.** Fixes https://b.corp.google.com/issues/412320087
87 lines
2.1 KiB
TypeScript
87 lines
2.1 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2025 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { ToolCallConfirmationDetails } from '@gemini-code/server';
|
|
import { FunctionDeclaration } from '@google/genai';
|
|
|
|
/**
|
|
* Interface representing the base Tool functionality
|
|
*/
|
|
export interface Tool<
|
|
TParams = unknown,
|
|
TResult extends ToolResult = ToolResult,
|
|
> {
|
|
/**
|
|
* The internal name of the tool (used for API calls)
|
|
*/
|
|
name: string;
|
|
|
|
/**
|
|
* The user-friendly display name of the tool
|
|
*/
|
|
displayName: string;
|
|
|
|
/**
|
|
* Description of what the tool does
|
|
*/
|
|
description: string;
|
|
|
|
/**
|
|
* Function declaration schema from @google/genai
|
|
*/
|
|
schema: FunctionDeclaration;
|
|
|
|
/**
|
|
* Validates the parameters for the tool
|
|
* @param params Parameters to validate
|
|
* @returns An error message string if invalid, null otherwise
|
|
*/
|
|
validateToolParams(params: TParams): string | null;
|
|
|
|
/**
|
|
* Gets a pre-execution description of the tool operation
|
|
* @param params Parameters for the tool execution
|
|
* @returns A markdown string describing what the tool will do
|
|
* Optional for backward compatibility
|
|
*/
|
|
getDescription(params: TParams): string;
|
|
|
|
/**
|
|
* Determines if the tool should prompt for confirmation before execution
|
|
* @param params Parameters for the tool execution
|
|
* @returns Whether execute should be confirmed.
|
|
*/
|
|
shouldConfirmExecute(
|
|
params: TParams,
|
|
): Promise<ToolCallConfirmationDetails | false>;
|
|
|
|
/**
|
|
* Executes the tool with the given parameters
|
|
* @param params Parameters for the tool execution
|
|
* @returns Result of the tool execution
|
|
*/
|
|
execute(params: TParams): Promise<TResult>;
|
|
}
|
|
|
|
export interface ToolResult {
|
|
/**
|
|
* Content meant to be included in LLM history.
|
|
* This should represent the factual outcome of the tool execution.
|
|
*/
|
|
llmContent: string;
|
|
|
|
/**
|
|
* Markdown string for user display.
|
|
* This provides a user-friendly summary or visualization of the result.
|
|
*/
|
|
returnDisplay: ToolResultDisplay;
|
|
}
|
|
|
|
export type ToolResultDisplay = string | FileDiff;
|
|
|
|
export interface FileDiff {
|
|
fileDiff: string;
|
|
}
|